-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Roofit ad ichep 2024 63206 comp branch with changes on main
#1020
Merged
anigamova
merged 34 commits into
cms-analysis:roofit_ad_ichep_2024_63206_comp
from
pkausw:roofit_ad_ichep_2024_63206_comp_update
Nov 18, 2024
Merged
Update Roofit ad ichep 2024 63206 comp branch with changes on main
#1020
anigamova
merged 34 commits into
cms-analysis:roofit_ad_ichep_2024_63206_comp
from
pkausw:roofit_ad_ichep_2024_63206_comp_update
Nov 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The constructor that just takes a string is deprecated and will be removed in ROOT 6.34.
Use RooDataSet constructor that takes `RooFit::WeightVar` argument
…632_fromcvmfs Adding build with ROOT 6.32.06
Bugfix. Also added weight in RooArgSet in line 218.
Update cvmfs-ci.yml with a stable ROOT 6.32.06 release
Remove py2.7 build in CI
* Fix the docstring (EFT->QuadraticScaling, is the filename) and also allow_pickle=True for reading dicts from np gz * Depracating py2 for combine v10 (cms-analysis#1014) Remove py2.7 build in CI --------- Co-authored-by: Jonathon Langford <[email protected]>
This makes it easy to re-use the mathematical functions in generated code. It's part of the `guitargeek/roofit_ad_ichep_2024` branch.
Factor out some mathematical details into free functions
anigamova
merged commit Nov 18, 2024
8e63497
into
cms-analysis:roofit_ad_ichep_2024_63206_comp
0 of 7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves merge conflicts with the additional commits to
main
. After the merge, this will be the basis for some performance studies in the context of the new auto diff feature in roofit