Fix cronjob options #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nothingface0
added a commit
that referenced
this pull request
Jun 12, 2024
commit bf979da Merge: 8a0b6d6 a4b12a8 Author: Dimitris Papagiannis <[email protected]> Date: Wed Jun 12 15:05:12 2024 +0200 Merge pull request #23 from cms-DQM/fix_cronjob_options Fix cronjob options commit a4b12a8 Author: Dimitris Papagiannis <[email protected]> Date: Tue Jun 11 11:39:16 2024 +0200 Adjust request periods, rename function commit ac31088 Author: Dimitris Papagiannis <[email protected]> Date: Mon Jun 10 17:44:49 2024 +0200 Fix log commit b1ebd1a Author: Dimitris Papagiannis <[email protected]> Date: Mon Jun 10 17:41:03 2024 +0200 Rename config variable, change value commit 1dc5e03 Author: Dimitris Papagiannis <[email protected]> Date: Mon Jun 10 17:30:50 2024 +0200 Update configs for deployments commit 9650e4d Author: Dimitris Papagiannis <[email protected]> Date: Mon Jun 10 17:26:18 2024 +0200 Fix cronjob options commit ec71233 Author: Dimitris Papagiannis <[email protected]> Date: Mon Jun 10 17:26:05 2024 +0200 Skip runs lower than MINIMUM_CMS_RUN_NUMBER commit e141f2b Author: Dimitris Papagiannis <[email protected]> Date: Mon Jun 10 17:25:22 2024 +0200 Extra logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cronjob library was not working given the configuration it was being passed, e.g., a
*/3600 * * * * *crontab was expected to run every 1 hour, but thenode-cronlibrary was ignoring any value greater than 60 and it was running every 1 minute.This PR makes the cronjob options in
config.jsmodify the minute part of the crontab instead, as there's no way that a query to OMS for the latest runs would need to be run more frequently than every 1 minute from our side.Variable names are updated to reflect their purpose.
Extra logging is also added