Skip to content

Commit

Permalink
Merge pull request #26 from gabrielmscampos/master
Browse files Browse the repository at this point in the history
For completion and future reference, this endpoint (joint_lumisection_ranges) is an aggregate of oms_lumisection_ranges and rr_lumisection_ranges.

Those are used mostly in the frontend, in the modal that appears when clicking LS (next to Manage) for a specific run.

The OMS LUMISECTIONS button uses oms_lumisection_ranges, the RR LUMISECTIONS uses the rr_lumisection_ranges and the BOTH button uses the joint_lumisection_ranges. All calls to each endpoint from the frontend are passed the dataset argument, but the joint_lumisection_ranges was ignoring it, always using online instead. This was probably not the intended functionality.
  • Loading branch information
nothingface0 authored Oct 1, 2024
2 parents 6d76a74 + 24dbc35 commit 4137ea0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion runregistry_backend/controllers/lumisection.js
Original file line number Diff line number Diff line change
Expand Up @@ -779,7 +779,7 @@ exports.get_rr_and_oms_lumisection_ranges = async (req, res) => {
);
const oms_lumisections = await exports.get_oms_lumisections_for_dataset(
run_number,
'online'
dataset_name || 'online'
);
let joint_lumisections;
if (rr_lumisections.length >= oms_lumisections.length) {
Expand Down

0 comments on commit 4137ea0

Please sign in to comment.