Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement setup incuding hello_xr.py script #9

Closed
wants to merge 1 commit into from

Conversation

nlsdvl
Copy link

@nlsdvl nlsdvl commented Oct 11, 2022

the changes implement the synopsis described here: #3

hello_xr can be launched as a console script,
or explicitly as a python module python -m xr_examples.hello_xr

Copy link
Owner

@cmbruns cmbruns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for implementing this. Your contribution is much appreciated. I have a couple of requested changes.

@@ -0,0 +1,2 @@
from setuptools import setup
setup()
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to put a blank line at the end of each file to avoid the scary red circle thingy in the diff.

@@ -1,4 +0,0 @@
from xr_examples.hello_xr.main import main
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still want to use this file during development and testing; even if it's not intended for external users.

@cmbruns cmbruns closed this Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants