LFG: Safeguard LFGQueue::GroupUpdateUI against crash

cmangos · Sep 13, 2024 · 4e26029 · 4e26029
1 parent 225a371
commit 4e26029
Showing 1 changed file with 16 additions and 12 deletions.
diff --git a/src/game/LFG/LFGQueue.cpp b/src/game/LFG/LFGQueue.cpp
@@ -720,18 +720,7 @@ void LFGQueue::GroupUpdateUI(ObjectGuid leaderGuid, bool completed)
 
     sWorld.GetMessager().AddMessage([leaderGuid, completed, members](World* world)
     {
-        Player* player = sObjectMgr.GetPlayer(leaderGuid);
-
-        if (completed)
-        {
-            player->GetSession()->SendMeetingStoneComplete();
-            if (sWorld.getConfig(CONFIG_BOOL_CHANNEL_RESTRICTED_LFG) && player->GetSession()->GetSecurity() == SEC_PLAYER)
-                player->LeaveLFGChannel();
-        }
-        else
-            player->GetSession()->SendLFGUpdate();
-
-        for (auto& member : members)
+        if (Player* player = sObjectMgr.GetPlayer(leaderGuid))
         {
             if (completed)
             {
@@ -742,6 +731,21 @@ void LFGQueue::GroupUpdateUI(ObjectGuid leaderGuid, bool completed)
             else
                 player->GetSession()->SendLFGUpdate();
         }
+
+        for (auto& memberGuid : members)
+        {
+            if (Player* member = sObjectMgr.GetPlayer(memberGuid))
+            {
+                if (completed)
+                {
+                    member->GetSession()->SendMeetingStoneComplete();
+                    if (sWorld.getConfig(CONFIG_BOOL_CHANNEL_RESTRICTED_LFG) && member->GetSession()->GetSecurity() == SEC_PLAYER)
+                        member->LeaveLFGChannel();
+                }
+                else
+                    member->GetSession()->SendLFGUpdate();
+            }
+        }
     });
 }