-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding grammar for precondition a attributes #100
base: master
Are you sure you want to change the base?
Conversation
// RFC 3312 precondition | ||
push: 'precondition', | ||
reg: /^(curr|des|conf):(qos|\S*)(?: (mandatory|optional|none|failure|unknown))? (e2e|local|remote) (none|sendrecv|send|recv)/, | ||
names: ['state', 'type', 'strength', 'status', 'direction'], | ||
format: function (o) { | ||
var str = '%s:%s '; | ||
str += o.strength != null ? '%s ' : '%v'; | ||
str += o.status != null ? '%s ' : ''; | ||
str += o.direction != null ? '%s ' : ''; | ||
return str; | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be the part of the thing that you are actually adding. From a quick scan, looks sensible.
Are you able to add some tests for it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I tried but not sure why tests are not runnable. I'll spend more time.
I added parse and write tests for |
Thanks for this. This looks great to me. Now for the awkward part. It's actually been a while since I've had to do a release on this, and travis has shutdown since :| |
Hi Eirik, |
Hey, i've updated testing setup now, if you're able to update (nm, i can do it from here) - and it's all green - i can try to push this out later :-) |
Hi, I've just added the required grammar for parsing precondition
a
attributes based on RFC 3312.Sample: