Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: check the clusterpedia apiserver before test cases #705

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

Iceber
Copy link
Member

@Iceber Iceber commented Nov 19, 2024

What type of PR is this?

/kind failing-test

What this PR does / why we need it:
Both apiserver and clustersynchro manager trigger attempts to create database tables when they are started at the same time, and we have found from #702 that there are concurrency issues due to gorm design issues.

https://github.com/clusterpedia-io/clusterpedia/actions/runs/11732967909/job/33175301980?pr=702#step:4:818

go-gorm/gorm#6618

In production, it will automatically retry, but in testing, you need to add a check to avoid subsequent test failures.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@clusterpedia-bot
Copy link

Hi @Iceber,
Thanks for your pull request!
If the PR is ready, use the /auto-cc command to assign Reviewer to Review.
We will review it shortly.

Details

Instructions for interacting with me using comments are available here.
If you have questions or suggestions related to my behavior, please file an issue against the gh-ci-bot repository.

@clusterpedia-bot
Copy link

@Iceber

Failed add label kind/failing-test
Details

Instructions for interacting with me using comments are available here.
If you have questions or suggestions related to my behavior, please file an issue against the gh-ci-bot repository.

@Iceber Iceber force-pushed the test_add_apiserver_check branch from ba079cf to 34e9afc Compare November 19, 2024 06:23
@Iceber Iceber merged commit 04cc096 into main Nov 19, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants