Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 migrate golang from 1.20 to 1.21.3 #581

Merged
merged 1 commit into from
Oct 28, 2023
Merged

🌱 migrate golang from 1.20 to 1.21.3 #581

merged 1 commit into from
Oct 28, 2023

Conversation

khareyash05
Copy link
Member

What type of PR is this?
/kind deprecation

What this PR does / why we need it:
Bump Golang from 1.19 to 1.21 as 1.19 has reached end of life
Which issue(s) this PR fixes:
Fixes #NA

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@clusterpedia-bot
Copy link

Hi @khareyash05,
Thanks for your pull request!
If the PR is ready, use the /auto-cc command to assign Reviewer to Review.
We will review it shortly.

Details

Instructions for interacting with me using comments are available here.
If you have questions or suggestions related to my behavior, please file an issue against the gh-ci-bot repository.

@clusterpedia-bot
Copy link

@khareyash05

Failed add label kind/deprecation
Details

Instructions for interacting with me using comments are available here.
If you have questions or suggestions related to my behavior, please file an issue against the gh-ci-bot repository.

@khareyash05 khareyash05 mentioned this pull request Oct 24, 2023
Closed
@khareyash05
Copy link
Member Author

/auto-cc

Iceber
Iceber reviewed Oct 25, 2023
View reviewed changes
go.mod Outdated Show resolved Hide resolved
Iceber
Iceber reviewed Oct 26, 2023
View reviewed changes
builder.dockerfile Outdated Show resolved Hide resolved
Iceber
Iceber approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@Iceber Iceber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm， Thanks

@Iceber Iceber added the kind/dependencies Pull requests that update a dependency file label Oct 26, 2023
@Iceber
Copy link
Member

Iceber commented Oct 26, 2023

@khareyash05 Looks like the commit info and pr title need to be updated

@khareyash05 khareyash05 changed the title bump golang from 1.19 to 1.21 🌱 migrate golang from 1.19 to 1.21 Oct 26, 2023
@Iceber
Copy link
Member

Iceber commented Oct 26, 2023

This pr is bump golang from 1.20 to 1.21.3, not 1.19

and the commit message isn't updated

@khareyash05 khareyash05 changed the title 🌱 migrate golang from 1.19 to 1.21 🌱 migrate golang from 1.20 to 1.21.3 Oct 26, 2023
@khareyash05
Copy link
Member Author

khareyash05 commented Oct 26, 2023 •
edited
Loading

This pr is bump golang from 1.20 to 1.21.3, not 1.19

and the commit message isn't updated

Shall I merge all in one commit and then push? Also could you suggest me a commit message

@khareyash05
bump golang from 1.20 to 1.21.3
7d6a492 
Signed-off-by: Yash Khare <[email protected]>

update dependencies

Signed-off-by: Yash Khare <[email protected]>
@khareyash05
Copy link
Member Author

@Iceber Updated the PR

@Iceber
Copy link
Member

Iceber commented Oct 28, 2023

Shall I merge all in one commit and then push? Also could you suggest me a commit message

We try to use a single commit, unless splitting it makes it easier to understand.

@Iceber Iceber merged commit df00ef6 into clusterpedia-io:main Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Iceber Iceber Iceber approved these changes

Assignees
No one assigned
Labels
kind/dependencies Pull requests that update a dependency file size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khareyash05 @clusterpedia-bot @Iceber