Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dualsum #50

Merged
merged 42 commits into from
Nov 30, 2023
Merged

Dualsum #50

merged 42 commits into from
Nov 30, 2023

Conversation

MihaiSurdeanu
Copy link
Contributor

No description provided.

kwalcock and others added 30 commits November 8, 2023 09:53
@kwalcock
Try to isolate Breeze
dc81d44
@kwalcock
WIP
c777301
@kwalcock
Rename to Math, transpose
6018fdf
@kwalcock
Complete Breeze isolation
eab249a
@kwalcock
Fix it again
97e3d2b
@kwalcock
Try Emjl math
2ab8e60
@kwalcock
Test BreezeMath
2f91702
@kwalcock
Unit test Emjl math
f038c40
@kwalcock
Organize math better
92c269e
@kwalcock
Clean up types
42b2679
@kwalcock
Fix up test app
c3851f4
@kwalcock
Test better
e50c05d
@kwalcock
Make column matrix directly
b21c0a6
@kwalcock
Make column matrix directly
0d8a1ed
@kwalcock
Remove OnnxMath
8148de7
@kwalcock
Rename things
fd29280
@kwalcock
Move the BlasInstanceApp to apps subproject
b7c2326
@kwalcock
Only include necessary ejml parts
fb0d70d
@kwalcock
Add CommonsMath
cddb890
@kwalcock
Add some mkRowVector to tests
79084ca
@kwalcock
Add some logging
49ac525
@MihaiSurdeanu
use sum instead of concat in dual mode
f16b818
@kwalcock
Add CluMath
a75b72c
@kwalcock
Remove .t from main interface
72d210f
@kwalcock
Write some comment on CluMath
ff7c5d7
@kwalcock
Hide math files that aren't used
f3b5362
@MihaiSurdeanu
sum not concat in scala
2721d6e
@MihaiSurdeanu
use sum instead of concat everywhere.
21c0f34
@kwalcock
Merge branch 'dualsum' into kwalcock/mathWithDualSum
a41971e
@kwalcock
Do the sum
aa39eb9
kwalcock
kwalcock approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@kwalcock kwalcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be very difficult to check all the changes, but the important ones are the math in the encoder. This project needs to be published in order for processors to use it. It works best to publish from main, so it's a good time to merge this one.

@kwalcock
Copy link
Member

I need to publish the models before it will pass.

@kwalcock kwalcock merged commit 00f1a34 into main Nov 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwalcock kwalcock kwalcock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MihaiSurdeanu @kwalcock