Remove prototype package dependency #22
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Clover team,
Not sure if you want this PR but because of the reasons described in #16 we
were unable to use the SDK with the
prototype
package as a dependency.This change:
prototype
package as astandalone file that does not modify any globals (see
Class.js
).to point me at the code that generates these files from the Avro schemas
I'd be happy to update that, too.
I've tested this change in our app and it appears to work as expected
but we certainly don't exercise the entire SDK codebase.
Resolves #16