Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider switching away from prototype #16

Closed
firedev opened this issue Aug 9, 2016 · 1 comment
Closed

Consider switching away from prototype #16

firedev opened this issue Aug 9, 2016 · 1 comment

Comments

@firedev
Copy link

firedev commented Aug 9, 2016 •
edited
Loading

Please consider switching from prototype as it seems it is not intended to for the browser.

When you require('prototype') it blindly overwrites functions in Array and whatnot as described in AlyxRen/prototype.node.js#8

It would be great if you required the needed functions directly from lodash/* or used a similar implementation that does not pollute the global scope.

Thanks.
jstotz added a commit to springboardretail/remote-pay-cloud that referenced this issue Sep 7, 2016
@jstotz
Remove prototype package dependency
0ba52ea 
- Extracts the Class implementation from the prototype package as a
  standalone file that does not modify any globals (see Class.js).

- Updates README to describe new way of extending classes

NOTE: This manually patches the files generated by Avro to show how
they'll need to be generated.

Resolves clover#16
jstotz added a commit to springboardretail/remote-pay-cloud that referenced this issue Sep 7, 2016
@jstotz
Remove prototype package dependency
fb8318e 
- Extracts the Class implementation from the prototype package as a
  standalone file that does not modify any globals (see Class.js).

- Updates README to describe new way of extending classes

NOTE: This manually patches the files generated by Avro to show how
they'll need to be generated.

Resolves clover#16
@jstotz jstotz mentioned this issue Sep 7, 2016
Closed
@mike-clover-com
Copy link
Contributor

Resolved via #23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@firedev @mike-clover-com