Ensure discriminated resource names are prefixed with the parent resource name #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praneetloke
added a commit
that referenced
this pull request
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Endpoint paths that use a discriminator need to have their resource names prefixed with the parent resource. Note that the "parent resource" here just means the base resource name. For example, take the following endpoint
/services. If there is a discriminator mapping like this:Then the "web" resource should be named
ServicesWeborServicesStaticSite. This ensures that resources are "namespaced" by their base resource name.Note: This was already the case when handling POST request method but the same type of naming was needed in the other request methods as well, which is what this PR does.