style(frontend): fix frontend lint

Signed-off-by: rogerogers <[email protected]>
cloudwego · Jan 4, 2024 · 98187e1 · 98187e1
1 parent 13b97d4
commit 98187e1
Show file tree

Hide file tree

Showing 12 changed files with 17 additions and 11 deletions.
diff --git a/gomall/app/frontend/biz/service/about.go b/gomall/app/frontend/biz/service/about.go
@@ -16,6 +16,7 @@ package service
 
 import (
 	"context"
+
 	"github.com/cloudwego/hertz/pkg/common/utils"
 
 	common "github.com/cloudwego/biz-demo/gomall/app/frontend/hertz_gen/frontend/common"

diff --git a/gomall/app/frontend/biz/service/add_cart_item.go b/gomall/app/frontend/biz/service/add_cart_item.go
@@ -16,6 +16,7 @@ package service
 
 import (
 	"context"
+
 	"github.com/cloudwego/biz-demo/gomall/app/frontend/hertz_gen/frontend/cart"
 	common "github.com/cloudwego/biz-demo/gomall/app/frontend/hertz_gen/frontend/common"
 	"github.com/cloudwego/biz-demo/gomall/app/frontend/infra/rpc"
@@ -39,6 +40,7 @@ func (h *AddCartItemService) Run(req *cart.AddCartReq) (resp *common.Empty, err
 		Item: &rpccart.CartItem{
 			ProductId: req.ProductId,
 			Quantity:  req.ProductNum,
-		}})
+		},
+	})
 	return
 }
diff --git a/gomall/app/frontend/biz/service/checkout.go b/gomall/app/frontend/biz/service/checkout.go
@@ -42,6 +42,7 @@ func (h *CheckoutService) Run(req *checkout.CheckoutReq) (resp map[string]any, e
 
 	carts, err := rpc.CartClient.GetCart(h.Context, &rpccart.GetCartRequest{UserId: userId})
 	if err != nil {
+		return nil, err
 	}
 	var total float32
 	for _, v := range carts.Items {

diff --git a/gomall/app/frontend/biz/service/checkout_result.go b/gomall/app/frontend/biz/service/checkout_result.go
@@ -16,6 +16,7 @@ package service
 
 import (
 	"context"
+
 	"github.com/cloudwego/hertz/pkg/common/utils"
 
 	common "github.com/cloudwego/biz-demo/gomall/app/frontend/hertz_gen/frontend/common"

diff --git a/gomall/app/frontend/biz/service/checkout_waiting.go b/gomall/app/frontend/biz/service/checkout_waiting.go
@@ -16,6 +16,7 @@ package service
 
 import (
 	"context"
+
 	"github.com/cloudwego/biz-demo/gomall/app/frontend/hertz_gen/frontend/checkout"
 	"github.com/cloudwego/biz-demo/gomall/app/frontend/infra/rpc"
 	rpccheckout "github.com/cloudwego/biz-demo/gomall/app/frontend/kitex_gen/checkout"

diff --git a/gomall/app/frontend/biz/service/login.go b/gomall/app/frontend/biz/service/login.go
@@ -16,6 +16,7 @@ package service
 
 import (
 	"context"
+
 	auth "github.com/cloudwego/biz-demo/gomall/app/frontend/hertz_gen/frontend/auth"
 	"github.com/cloudwego/biz-demo/gomall/app/frontend/infra/rpc"
 	rpcuser "github.com/cloudwego/biz-demo/gomall/app/frontend/kitex_gen/user"

diff --git a/gomall/app/frontend/biz/service/logout.go b/gomall/app/frontend/biz/service/logout.go
@@ -34,6 +34,6 @@ func NewLogoutService(Context context.Context, RequestContext *app.RequestContex
 func (h *LogoutService) Run(req *common.Empty) (resp *common.Empty, err error) {
 	session := sessions.Default(h.RequestContext)
 	session.Clear()
-	session.Save()
+	session.Save() //nolint:errcheck
 	return
 }
diff --git a/gomall/app/frontend/biz/service/register.go b/gomall/app/frontend/biz/service/register.go
@@ -40,7 +40,6 @@ func (h *RegisterService) Run(req *auth.RegisterReq) (resp *common.Empty, err er
 		Password:        req.Password,
 		ConfirmPassword: req.Password,
 	})
-
 	if err != nil {
 		return nil, err
 	}

diff --git a/gomall/app/frontend/conf/conf.go b/gomall/app/frontend/conf/conf.go
@@ -15,7 +15,6 @@
 package conf
 
 import (
-	"io/ioutil"
 	"os"
 	"path/filepath"
 	"sync"
@@ -73,7 +72,7 @@ func GetConf() *Config {
 func initConf() {
 	prefix := "conf"
 	confFileRelPath := filepath.Join(prefix, filepath.Join(GetEnv(), "conf.yaml"))
-	content, err := ioutil.ReadFile(confFileRelPath)
+	content, err := os.ReadFile(confFileRelPath)
 	if err != nil {
 		panic(err)
 	}

diff --git a/gomall/app/frontend/infra/mtl/log.go b/gomall/app/frontend/infra/mtl/log.go
@@ -39,7 +39,7 @@ func initLog() {
 			FlushInterval: time.Minute,
 		}
 		server.RegisterShutdownHook(func() {
-			output.Sync()
+			output.Sync() //nolint:errcheck
 		})
 	}
 	log := hertzzap.NewLogger(opts...)

diff --git a/gomall/app/frontend/infra/mtl/metric.go b/gomall/app/frontend/infra/mtl/metric.go
@@ -17,11 +17,12 @@ package mtl
 import (
 	"context"
 	"fmt"
-	"github.com/cloudwego/biz-demo/gomall/app/frontend/conf"
-	"github.com/cloudwego/hertz/pkg/common/utils"
 	"net"
 	"net/http"
 
+	"github.com/cloudwego/biz-demo/gomall/app/frontend/conf"
+	"github.com/cloudwego/hertz/pkg/common/utils"
+
 	"github.com/cloudwego/hertz/pkg/app/server/registry"
 	"github.com/cloudwego/hertz/pkg/common/hlog"
 	"github.com/cloudwego/hertz/pkg/route"
@@ -58,8 +59,8 @@ func initMetric() route.CtxCallback {
 	}
 
 	http.Handle("/metrics", promhttp.HandlerFor(Registry, promhttp.HandlerOpts{}))
-	go http.ListenAndServe(fmt.Sprintf(":%d", conf.GetConf().Hertz.MetricsPort), nil)
+	go http.ListenAndServe(fmt.Sprintf(":%d", conf.GetConf().Hertz.MetricsPort), nil) //nolint:errcheck
 	return func(ctx context.Context) {
-		r.Deregister(registryInfo)
+		r.Deregister(registryInfo) //nolint:errcheck
 	}
 }
diff --git a/gomall/app/frontend/infra/mtl/tracing.go b/gomall/app/frontend/infra/mtl/tracing.go
@@ -42,6 +42,6 @@ func InitTracing() route.CtxCallback {
 	otel.SetTracerProvider(TracerProvider)
 
 	return route.CtxCallback(func(ctx context.Context) {
-		exporter.Shutdown(ctx)
+		exporter.Shutdown(ctx) //nolint:errcheck
 	})
 }