Addition of Upsert operation in Salesforce sink Plugin #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poojantcs
reviewed
Sep 23, 2024
| @@ -84,6 +84,12 @@ public static void createTempSourceBQTable() throws IOException, InterruptedExce | |||
| PluginPropertyUtils.pluginProp("InsertBQDataQueryFile")); | |||
| } | |||
|
|
|||
| @Before(order = 1, value = "@BQ_FAILURE_TEST") | |||
| public static void createTempSourceInvalidBQTable() throws IOException, InterruptedException { | |||
poojantcs
reviewed
Sep 23, 2024
| @@ -178,14 +178,14 @@ public static List<JsonObject> queryObject(String id, String objectName) { | |||
| public static void deletePushTopic(String pushTopicName) { | |||
| try { | |||
| PartnerConnection partnerConnection = new PartnerConnection( | |||
| Authenticator.createConnectorConfig(AuthenticatorCredentials.fromParameters(USERNAME, PASSWORD + SECURITYTOKEN, | |||
There was a problem hiding this comment.
Remove the unnecessary/non-targeted changes
poojantcs
reviewed
Sep 23, 2024
|
|
||
| QueryResult queryResult = SalesforceStreamingSourceConfig.runQuery( | ||
| partnerConnection, | ||
| String.format("SELECT Id FROM PushTopic WHERE Name = '%s'", pushTopicName) | ||
| partnerConnection, |
There was a problem hiding this comment.
Remove the unnecessary/non-targeted changes
poojantcs
reviewed
Sep 23, 2024
| @@ -204,7 +204,7 @@ public static void deletePushTopic(String pushTopicName) { | |||
| } catch (ConnectionException e) { | |||
| String message = SalesforceConnectionUtil.getSalesforceErrorMessageFromException(e); | |||
| throw new InvalidStageException( | |||
| String.format("Cannot connect to Salesforce API with credentials specified due to error: %s", message), e); | |||
| String.format("Cannot connect to Salesforce API with credentials specified due to error: %s", message), e); | |||
There was a problem hiding this comment.
Remove the unnecessary/non-targeted changes
poojantcs
reviewed
Sep 23, 2024
| @@ -269,7 +269,7 @@ public static String queryObjectId(String objectName) { | |||
| return uniqueRecordId; | |||
| } | |||
|
|
|||
| public static void updateObject(String id, String objectName) { | |||
| public static void updateObject(String id, String objectName) { | |||
There was a problem hiding this comment.
Remove the unnecessary/non-targeted changes
poojantcs
reviewed
Sep 23, 2024
| create table `DATASET.TABLE_NAME` (Name STRING, Col_Timestamp__c TIMESTAMP, Col_Date__c DATE, Col_Currency__c FLOAT64, | ||
| Col_Email__c STRING, Col_Number__c FLOAT64, Col_GeoLocation__Latitude__s FLOAT64, | ||
| Col_GeoLocation__Longitude__s FLOAT64, Col__c STRING, Col_Url__c STRING, Col_Time__c TIME, Col_Text__c STRING) | ||
| create table `DATASET.TABLE_NAME` (Id__c FLOAT64, Name STRING, Col_Timestamp__c TIMESTAMP, Col_Date__c DATE, Col_Currency__c FLOAT64, |
There was a problem hiding this comment.
Is this change done to fix the broken environment dependent tests?
There was a problem hiding this comment.
Yes, we have done this change to fix the broken environment dependent tests.
poojantcs
reviewed
Sep 23, 2024
| insert into `DATASET.TABLE_NAME` (Name, Col_Timestamp__c, Col_Date__c, Col_Currency__c, Col_Email__c, Col_Number__c, | ||
| Col_GeoLocation__Latitude__s, Col_GeoLocation__Longitude__s, Col__c, Col_Url__c, Col_Time__c, Col_Text__c) values | ||
| ('adam','2019-03-10 04:50:01 UTC','2021-01-28',61.823765812,'[email protected]',898365444,37.794116,-122.3432, | ||
| insert into `DATASET.TABLE_NAME` (Id__c, Name, Col_Timestamp__c, Col_Date__c, Col_Currency__c, Col_Email__c, Col_Number__c, |
There was a problem hiding this comment.
Is this change done to fix the broken environment dependent tests?
There was a problem hiding this comment.
Yes, we have done this change to fix the broken environment dependent tests.
poojantcs
reviewed
Sep 23, 2024
| @@ -18,7 +18,7 @@ invalid.admin.consumer.secret=lmnop891011 | |||
| #SOQL Query | |||
| simple.query=SELECT Id, Name, Phone FROM Account | |||
| test.query=SELECT Id,Name,Col_Timestamp__c,Col_Date__c,Col_Currency__c,Col_Email__c,Col_Number__c,\ | |||
| Col_GeoLocation__Latitude__s,Col_GeoLocation__Longitude__s,Col__c,Col_Url__c,Col_Time__c,Col_Text__c FROM Automation_custom__c | |||
| Col__c,Col_Url__c,Col_Time__c,Col_Text__c FROM Automation_custom__c | |||
There was a problem hiding this comment.
Is this change done to fix the broken environment dependent tests?
There was a problem hiding this comment.
Yes, we have done this change to fix the broken environment dependent tests.
poojantcs
reviewed
Sep 23, 2024
| "Col_Currency__c":123.456,"Col_Email__c":"[email protected]","Col_Number__c":1008.0,\ | ||
| "Col__c":"984746334","Col_Url__c":"abc/123","Col_Time__c":"05:00:00.000Z","Col_Text__c":"shsss"} | ||
|
|
||
| url = http://10.132.0.45:3128 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.