Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLUGIN-430] Remove unused field :ReferenceName from GCS/BQ argument setter #59

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

psainics
Copy link
Collaborator

Remove unused field :ReferenceName from GCS/BQ argument setter

Jira : PLUGIN-430

Description

GCS/BQ argument setters have field :ReferenceName mentioned in the docs and the plugin design file, being a action plugin the field is not used in the code hence it's mention in the docs may cause confusion.

UI Field

  • Modified BigQueryArgumentSetter-action.json

  • Modified GCSArgumentSetter-action.json

    As the field was not used in code removing them from the plugin design does not cause and visual change on plugin UI on the brower.

Docs

  • Modified BigQueryArgumentSetter-action.md
  • Modified GCSArgumentSetter-action.md

Code change

  • No Changes made to docs.

Unit Tests

  • No Changes made to unit tests.

@psainics psainics added documentation Improvements or additions to documentation refactor This needs change to conform to standards labels Sep 11, 2024
@psainics psainics force-pushed the patch/arg-setter-ref-name-field branch from dfeaefe to 0597d3c Compare September 12, 2024 07:53
@psainics psainics merged commit a1a4049 into develop Sep 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation refactor This needs change to conform to standards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant