Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLUGIN-1742] Add GCSEmptyInputFormat (Allow Empty Input) #57

Merged
merged 3 commits into from
Sep 12, 2024
Merged

[PLUGIN-1742] Add GCSEmptyInputFormat (Allow Empty Input) #57

merged 3 commits into from
Sep 12, 2024

Conversation

psainics
Copy link
Collaborator

@psainics psainics commented Sep 9, 2024

Add GCSEmptyInputFormat (Allow Empty Input)

Jira : PLUGIN-1742

Description

Add GCSEmptyInputFormat to allow user to run the pipeline with invalid source if Allow Empty Input is set to true.

  • The pipeline would fail with an invalid source, when the option is set to false (default behavior)
    • Invalid source refers to a GCS path that does not exist
  • This was hard coded to false to avoid the class loading error, which requires to add a separate EmptyInputFormat

Code change

  • Added GCSEmptyInputFormat.java
  • Modified GCSSource.java

@psainics psainics added bug Something isn't working enhancement New feature or request labels Sep 9, 2024
@psainics psainics force-pushed the patch/empty-input-format branch from e329fe5 to 4fe66b7 Compare September 12, 2024 07:22
@psainics psainics merged commit e9e2391 into develop Sep 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikasrathee-cs vikasrathee-cs Awaiting requested review from vikasrathee-cs

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@psainics