E2E cloud datastore #49
Conversation
AnkitCLI
force-pushed
the
e2e-clouddatastore-ITN
branch
2 times, most recently
from
85efbc2 to
aa4d62a
Compare
| @@ -0,0 +1,37 @@ | |||
| /* | |||
| * Copyright © 2021 Cask Data, Inc. | |||
| @@ -0,0 +1,38 @@ | |||
| /* | |||
| * Copyright © 2021 Cask Data, Inc. | |||
There was a problem hiding this comment.
change here as well to 2024
| @RunWith(Cucumber.class) | ||
| @CucumberOptions( | ||
| features = {"src/e2e-test/features"}, | ||
| glue = {"io.cdap.plugin.datastore.stepsdesign", "io.cdap.plugin.gcs.stepsdesign", |
There was a problem hiding this comment.
No need to add gcs and big query steps design in glue. Are you using them in your datastore tests?
There was a problem hiding this comment.
removed the unused files
| @CucumberOptions( | ||
| features = {"src/e2e-test/features"}, | ||
| glue = {"io.cdap.plugin.datastore.stepsdesign", "io.cdap.plugin.gcs.stepsdesign", | ||
| "io.cdap.plugin.common.stepsdesign", "io.cdap.plugin.bigquery.stepsdesign", "stepsdesign"}, |
There was a problem hiding this comment.
Check here as well and remove if not needed.
There was a problem hiding this comment.
removed the unused files
| fieldName=firstName | ||
| name=Antonio | ||
| age=23 | ||
| result= |
There was a problem hiding this comment.
yes the value is blank for true or false. Blank value represents true.
| @@ -0,0 +1,20 @@ | |||
| package io.cdap.plugin.datastore.stepsdesign; | |||
There was a problem hiding this comment.
Please add the license and java doc. Refer any existing action class.
There was a problem hiding this comment.
Execute the tests with verify command to for check styles locally.
There was a problem hiding this comment.
added the javadoc and separate directories.
| @@ -0,0 +1,13 @@ | |||
| package io.cdap.plugin.datastore.stepsdesign; | |||
There was a problem hiding this comment.
Please add the license and java doc. Refer any existing action class.
| @@ -0,0 +1,17 @@ | |||
| package io.cdap.plugin.datastore.stepsdesign; | |||
There was a problem hiding this comment.
Please add the license and java doc. Refer any existing action class.
| @@ -0,0 +1,17 @@ | |||
| package io.cdap.plugin.datastore.stepsdesign; | |||
There was a problem hiding this comment.
Also add separate folder structure for actions, locators, stepdesign and place the respective class files in each folder. refer folder structuring of any existing plugin.
| # License for the specific language governing permissions and limitations under | ||
| # the License. | ||
|
|
||
| @DataStore |
There was a problem hiding this comment.
Please add the datastore folder name in e2e.yml file to execute the tests on GitHub.
| Then Validate OUT record count is equal to IN record count | ||
| Then Open and capture logs | ||
| Then Verify the pipeline status is "Succeeded" | ||
| Then Close the pipeline logs |
There was a problem hiding this comment.
Add data validation step in all scenarios, refer ITN if added.
There was a problem hiding this comment.
Right now we are not going with data validation step for datastore.
AnkitCLI
force-pushed
the
e2e-clouddatastore-ITN
branch
3 times, most recently
from
cd695ca to
1493856
Compare
| */ | ||
| public class DataStoreActions { | ||
| static { | ||
|
|
There was a problem hiding this comment.
remove the extra space
| SeleniumHelper.getPropertiesLocators(DataStoreLocators.class); | ||
| } | ||
|
|
||
| public static void enterKind(String kindName) { |
There was a problem hiding this comment.
Add small java doc for methods.
| ElementHelper.sendKeys(DataStoreLocators.kind, kindName); | ||
| } | ||
|
|
||
| public static void enterAncestor() { |
There was a problem hiding this comment.
Why are we creating method to send text, can't we use existing framework steps ?
There was a problem hiding this comment.
we are going with as per ganesh's comments to go for locators with data-testid if we can use them, so i just use these 2 new fields with data-testid.
AnkitCLI
force-pushed
the
e2e-clouddatastore-ITN
branch
from
1493856 to
04ca11f
Compare
AnkitCLI
force-pushed
the
e2e-clouddatastore-ITN
branch
2 times, most recently
from
93d849f to
8584235
Compare
AnkitCLI
force-pushed
the
e2e-clouddatastore-ITN
branch
3 times, most recently
from
c2cdb2b to
5f25453
Compare
AnkitCLI
force-pushed
the
e2e-clouddatastore-ITN
branch
2 times, most recently
from
e80ad17 to
90c4a30
Compare
AnkitCLI
force-pushed
the
e2e-clouddatastore-ITN
branch
2 times, most recently
from
b2510c1 to
36cafd1
Compare
AnkitCLI
force-pushed
the
e2e-clouddatastore-ITN
branch
from
36cafd1 to
d24f456
Compare
No description provided.