Pubsub new tests e2e phase 2 #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Then Validate OUT record count is equal to IN record count | ||
| And Stop the pipeline | ||
| Then Verify the pipeline status is "Stopped" | ||
| Then Verify the pipeline status is "Stopped" |
There was a problem hiding this comment.
I don't see data validation step for any of the features, are we working on it or skipping it ?
|
Just one comment, otherwise LGTM. |
AnkitCLI
force-pushed
the
pubsub_new_tests_e2e_ph2
branch
5 times, most recently
from
a849c5c to
442937a
Compare
AnkitCLI
force-pushed
the
pubsub_new_tests_e2e_ph2
branch
from
442937a to
0a18789
Compare
NavdeepCS
force-pushed
the
develop
branch
4 times, most recently
from
fc2efdf to
5f4f137
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.