forked from data-integrations/google-cloud
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retry for big query execute #28
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psainics
force-pushed
the
patch-retry-bigQuery-execute
branch
2 times, most recently
from
November 6, 2023 07:19
c62793c
to
9dd2870
Compare
src/test/java/io/cdap/plugin/gcp/bigquery/action/BigQueryExecuteTest.java
Outdated
Show resolved
Hide resolved
src/main/java/io/cdap/plugin/gcp/bigquery/action/BigQueryExecute.java
Outdated
Show resolved
Hide resolved
src/main/java/io/cdap/plugin/gcp/bigquery/action/BigQueryExecute.java
Outdated
Show resolved
Hide resolved
.handle(BigQueryJobExecutionException.class) | ||
.withBackoff(initialRetryDuration, maxRetryDuration, multiplier) | ||
.withMaxRetries(maxRetryCount) | ||
.onRetry(event -> LOG.debug("Retrying BigQuery Execute job. Retry count: {}", event.getAttemptCount())) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of BQ execute job, mention BQ job so it can be reused in source plugin also later on and if there is any common util between BQ plugins, move retrypolicy method to that class. E.g. BigQueryUtil
src/main/java/io/cdap/plugin/gcp/bigquery/action/BigQueryExecute.java
Outdated
Show resolved
Hide resolved
src/main/java/io/cdap/plugin/gcp/bigquery/action/BigQueryExecute.java
Outdated
Show resolved
Hide resolved
src/test/java/io/cdap/plugin/gcp/bigquery/action/BigQueryExecuteTest.java
Show resolved
Hide resolved
src/test/java/io/cdap/plugin/gcp/bigquery/action/BigQueryExecuteTest.java
Outdated
Show resolved
Hide resolved
psainics
force-pushed
the
patch-retry-bigQuery-execute
branch
3 times, most recently
from
November 16, 2023 08:34
57ae3ae
to
b74a689
Compare
psainics
force-pushed
the
patch-retry-bigQuery-execute
branch
11 times, most recently
from
December 11, 2023 20:01
34a7113
to
ddadce4
Compare
psainics
force-pushed
the
patch-retry-bigQuery-execute
branch
2 times, most recently
from
December 14, 2023 05:12
7a56dad
to
2793ac7
Compare
Added BQ Retry
vikasrathee-cs
force-pushed
the
patch-retry-bigQuery-execute
branch
from
December 21, 2023 08:24
2793ac7
to
a5e3e7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement retry feature for BigQuery Execute Plugin
Jira : PLUGIN-1715
jobBackendError
,jobInternalError
.Code Changes
dev.failsafe
that handles the retry logic based on the exception raised.Unit Tests