-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SystemAdmin feature scenarios addition #3
Conversation
Then Click on the Configuration link on the System admin page | ||
Then Select "systemPreferences" option from Configuration page | ||
Then Click on edit system preferences to set system preferences | ||
Then Enter key value pairs to set preferences: "keyValue" with values from json: "systemPreferences1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name of this step definitions looks a bit confusing, Can we do something like this ..
Set system preferences with key: "keyValue" and value: "systemPreferences1"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed the step definition
Then Select "systemPreferences" option from Configuration page | ||
Then Click on edit system preferences to set system preferences | ||
Then Enter key value pairs to set preferences: "keyValue" with values from json: "systemPreferences1" | ||
Then Click on Save and Close button to save the preferences |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Click on the Save preferences button
or Save the preferences
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The button name is 'Save & Close' shall I add the suggested step?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed the step definition
Then Click on Delete button to delete the added preferences | ||
Then Click on Save and Close button to save the preferences | ||
|
||
Scenario:Validate user is able to successfully reload system artifacts using reload |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do we check here if system artifacts are loaded, like are we validating something ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here in UI there is no change which happens after reload.
Then Click on Reload button on popup to reload the System Artifacts successfully | ||
Then Select "systemPreferences" option from Configuration page | ||
|
||
Scenario:Validate user is able to open compute profile page and select a provisioner |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again we have selected the provisioner from UI but how do we validate it ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we are adding only the design time scenarios we will be adding the validation steps when the requirement for creation with end to end tests is planned in upcoming tasks. Now we are only checking the basic sanity checks. It's an on going task for addition at framework level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the validation step.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest of the changes looks good, I am not actually sure about this one. If we will be creating more scenarios for this use case then its okay but for creating a compute profile if this is the only scenario we may have to complete it.
- Selected an provisioner
existingdataproc
- Done - Configure the provisioner after filling the details create it.
- Then check if the provisoiner which we created is present under computer profile list with same name.
This will be a complete end to end test case for this I believe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now added the validation as suggested to check provisioner created.
6e6217f
to
9322579
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
2fac2df
to
3cab459
Compare
3cab459
to
c6d47d5
Compare
ff14c7e
to
479e615
Compare
1a8ca79
to
3c62921
Compare
61b7922
to
f359c11
Compare
ed98cac
to
25bc105
Compare
25bc105
to
1c41163
Compare
51b27e3
to
12536cb
Compare
12536cb
to
dbbae99
Compare
SystemAdmin feature scenarios addition