Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SystemAdmin feature scenarios addition #3

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Conversation

itsmekumari
Copy link
Collaborator

SystemAdmin feature scenarios addition

Then Click on the Configuration link on the System admin page
Then Select "systemPreferences" option from Configuration page
Then Click on edit system preferences to set system preferences
Then Enter key value pairs to set preferences: "keyValue" with values from json: "systemPreferences1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name of this step definitions looks a bit confusing, Can we do something like this ..

Set system preferences with key: "keyValue" and value: "systemPreferences1"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the step definition

Then Select "systemPreferences" option from Configuration page
Then Click on edit system preferences to set system preferences
Then Enter key value pairs to set preferences: "keyValue" with values from json: "systemPreferences1"
Then Click on Save and Close button to save the preferences
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click on the Save preferences button or Save the preferences

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The button name is 'Save & Close' shall I add the suggested step?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the step definition

Then Click on Delete button to delete the added preferences
Then Click on Save and Close button to save the preferences

Scenario:Validate user is able to successfully reload system artifacts using reload
Copy link
Collaborator

@Vipinofficial11 Vipinofficial11 Sep 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we check here if system artifacts are loaded, like are we validating something ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here in UI there is no change which happens after reload.

Then Click on Reload button on popup to reload the System Artifacts successfully
Then Select "systemPreferences" option from Configuration page

Scenario:Validate user is able to open compute profile page and select a provisioner
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again we have selected the provisioner from UI but how do we validate it ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we are adding only the design time scenarios we will be adding the validation steps when the requirement for creation with end to end tests is planned in upcoming tasks. Now we are only checking the basic sanity checks. It's an on going task for addition at framework level.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the validation step.

Copy link
Collaborator

@Vipinofficial11 Vipinofficial11 Sep 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest of the changes looks good, I am not actually sure about this one. If we will be creating more scenarios for this use case then its okay but for creating a compute profile if this is the only scenario we may have to complete it.

  1. Selected an provisioner existingdataproc - Done
  2. Configure the provisioner after filling the details create it.
  3. Then check if the provisoiner which we created is present under computer profile list with same name.

This will be a complete end to end test case for this I believe.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now added the validation as suggested to check provisioner created.

@itsmekumari
Copy link
Collaborator Author

itsmekumari commented Sep 27, 2023

Screenshot 2023-09-27 at 5 28 36 PM Screenshot 2023-09-27 at 5 53 25 PM

@itsmekumari itsmekumari force-pushed the e2e_sysadmin branch 2 times, most recently from 6e6217f to 9322579 Compare October 5, 2023 12:19
Copy link
Collaborator

@rahuldash171 rahuldash171 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@itsmekumari itsmekumari force-pushed the e2e_sysadmin branch 2 times, most recently from 2fac2df to 3cab459 Compare October 20, 2023 13:08
@itsmekumari itsmekumari force-pushed the e2e_sysadmin branch 3 times, most recently from ff14c7e to 479e615 Compare November 2, 2023 12:18
@Vipinofficial11 Vipinofficial11 force-pushed the e2e_sysadmin branch 3 times, most recently from ed98cac to 25bc105 Compare December 5, 2023 13:23
@itsmekumari itsmekumari force-pushed the e2e_sysadmin branch 4 times, most recently from 51b27e3 to 12536cb Compare January 4, 2024 10:32
@Vipinofficial11 Vipinofficial11 merged commit 489ba81 into develop Jan 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants