Skip to content

Commit

Permalink
Merge pull request cdapio#15482 from cdapio/deploy-error-update
Browse files Browse the repository at this point in the history
CDAP-20914: Updated plugin missing error copytext
  • Loading branch information
samdgupi authored Dec 13, 2023
2 parents 4534daf + e229dab commit 9e3ea33
Showing 1 changed file with 7 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -146,9 +146,9 @@ protected <T extends PluginConfigurer & DatasetConfigurer> PipelineSpecGenerator
* also register all plugins used by the pipeline and create any error datasets used by the
* pipeline.
*
* A valid pipeline has the following properties:
* <p>A valid pipeline has the following properties:
*
* All stages in the pipeline have a unique name. Source stages have at least one output and no
* <p>All stages in the pipeline have a unique name. Source stages have at least one output and no
* inputs. Sink stages have at least one input and no outputs. There are no cycles in the
* pipeline. All inputs into a stage have the same schema.
*
Expand Down Expand Up @@ -525,9 +525,7 @@ private Object getPlugin(String stageName, ETLPlugin etlPlugin,
if (plugin == null) {
String errorMessage = String.format("Plugin named '%s' of type '%s' not found.", pluginName,
type);
String correctiveAction = String.format(
"Make sure plugin '%s' of type '%s' is already deployed.",
pluginName, type);
String correctiveAction = "Please make sure plugin is deployed in the namespace and try again";
ArtifactSelectorConfig requested = etlPlugin.getArtifactConfig();
ArtifactId requestedArtifactId = requested == null ? null :
new ArtifactId(requested.getName(), new ArtifactVersion(requested.getVersion()),
Expand Down Expand Up @@ -557,15 +555,15 @@ private Object getPlugin(String stageName, ETLPlugin etlPlugin,
/**
* Validate that this is a valid pipeline. A valid pipeline has the following properties:
*
* All stages in the pipeline have a unique name. Source stages have at least one output and no
* <p>All stages in the pipeline have a unique name. Source stages have at least one output and no
* inputs. Sink stages have at least one input and no outputs. There are no cycles in the
* pipeline. All inputs into a stage have the same schema. ErrorTransforms only have BatchSource,
* Transform, or BatchAggregator as input stages. AlertPublishers have at least one input and no
* outputs and don't have SparkSink or BatchSink as input. Action stages can only be at the start
* or end of the pipeline. Condition stages have at most 2 outputs. Each stage on a condition's
* output branch has at most a single input.
*
* Returns the stages in the order they should be configured to ensure that all input stages are
* <p>Returns the stages in the order they should be configured to ensure that all input stages are
* configured before their output.
*
* @param config the user provided configuration
Expand Down Expand Up @@ -751,7 +749,7 @@ private boolean isSink(String pluginType) {
}

/**
* Just a container for StageSpec and pipeline properties set by the stage
* Just a container for StageSpec and pipeline properties set by the stage.
*/
protected static class ConfiguredStage {

Expand All @@ -770,7 +768,7 @@ public StageSpec getStageSpec() {

/**
* Make sure that the stages on the condition branches do not have more than one incoming
* connections
* connections.
*
* @param conditionStages the set of condition stages in the pipeline
* @param dag the dag of connections
Expand Down

0 comments on commit 9e3ea33

Please sign in to comment.