Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #134 - Does not create http_forward when aws_lb_target_group.default is disabled #149

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fixes #134 - Does not create http_forward when aws_lb_target_group.default is disabled #149

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d1a69cb
Fixes #134 - Skips http_forward when aws_lb_target_group.default is d…
spazm Oct 25, 2023
60d26fb
Merge branch 'main' into 134_disable_arn_when_default_target_group_di…
kevcube Dec 12, 2023
d8b42cf
Merge branch 'main' into 134_disable_arn_when_default_target_group_di…
kevcube Dec 12, 2023
58343f3
Merge branch 'main' into 134_disable_arn_when_default_target_group_di…
hans-d Mar 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,13 +151,20 @@ resource "aws_lb_target_group" "default" {
resource "aws_lb_listener" "http_forward" {
#bridgecrew:skip=BC_AWS_GENERAL_43 - Skipping Ensure that load balancer is using TLS 1.2.
#bridgecrew:skip=BC_AWS_NETWORKING_29 - Skipping Ensure ALB Protocol is HTTPS
count = module.this.enabled && var.http_enabled && var.http_redirect != true ? 1 : 0
count = (
module.this.enabled &&
var.http_enabled &&
var.http_redirect != true &&
(var.listener_http_fixed_response != null || var.default_target_group_enabled)
? 1 : 0
)
load_balancer_arn = one(aws_lb.default[*].arn)
port = var.http_port
protocol = "HTTP"
tags = merge(module.this.tags, var.listener_additional_tags)

default_action {
# target_group_arn is required when type is forward
target_group_arn = var.listener_http_fixed_response != null ? null : one(aws_lb_target_group.default[*].arn)
type = var.listener_http_fixed_response != null ? "fixed-response" : "forward"

Expand Down
Loading