Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: exclude dependabot from codeowner validation and auto format #454

Merged
merged 6 commits into from
Oct 26, 2023

Conversation

nitrocode
Copy link
Member

@nitrocode nitrocode commented Oct 25, 2023

what

  • exclude dependabot codeowner validation and auto format

why

  • This will make it easier for tiny dependabot PRs to be merged in without creating personal branches to correct dependencies
  • The easier it is to update dependencies, the more likely they can be kept up to date

references

@nitrocode nitrocode requested review from a team as code owners October 25, 2023 20:47
- uses: mszostok/[email protected]
if: github.event.pull_request.head.repo.full_name != github.repository
# This condition verifies that the PR repo does NOT equal the Github Repo and it's NOT dependabot
if: ${{ (github.event.pull_request.head.repo.full_name != github.repository) && (github.actor != 'dependabot[bot]') }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't need to skip this check as it does require any seconds unlike the previous step.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in d06ec63

@osterman
Copy link
Member

@nitrocode we also need to skip auto-format on these
image

@nitrocode nitrocode changed the title ci: exclude dependabot from codeowner validation ci: exclude dependabot from codeowner validation and auto format Oct 26, 2023
@nitrocode nitrocode requested a review from osterman October 26, 2023 03:36
@nitrocode nitrocode added the no-release Do not create a new release (wait for additional code changes) label Oct 26, 2023
@osterman osterman merged commit 276f333 into master Oct 26, 2023
6 of 7 checks passed
@osterman osterman deleted the exclude-dependabot-from-codeowners branch October 26, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-release Do not create a new release (wait for additional code changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants