Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Bump module to Go 1.23 #280

Merged
merged 1 commit into from
Jan 10, 2025
Merged

feat: Bump module to Go 1.23 #280

merged 1 commit into from
Jan 10, 2025

Conversation

ctlong
Copy link
Member

@ctlong ctlong commented Jan 10, 2025

Description

  • Requires go1.23.
  • Sets toolchain to latest go1.23 version, which is go1.23.4.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing performed?

  • Unit tests
  • Integration tests

Checklist:

  • This PR is being made against the main branch, or relevant version branch
  • I have made corresponding changes to the documentation
  • I have added testing for my changes

@ctlong
feat: Bump module to Go 1.23
525550d 
* Requires go1.23.
* Sets toolchain to latest go1.23 version, which is go1.23.4.
@ctlong ctlong requested a review from a team as a code owner January 10, 2025 01:39
@ctlong ctlong requested a review from a team January 10, 2025 01:40
chombium
chombium approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@chombium chombium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chombium chombium merged commit 45fe466 into main Jan 10, 2025
8 checks passed
@ctlong ctlong deleted the bump/go/1.23 branch January 10, 2025 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chombium chombium chombium approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ctlong @chombium