Make new status field on cfapp optional

This stops the patching failing when an existing app is reconciled after upgrading korifi. Also make vcapServicesSecretName optional for consistency Co-authored-by: Giuseppe Capizzi <[email protected]>
cloudfoundry · Feb 16, 2023 · a7c13bb · a7c13bb
1 parent a22af23
commit a7c13bb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/controllers/api/v1alpha1/cfapp_types.go b/controllers/api/v1alpha1/cfapp_types.go
@@ -52,13 +52,15 @@ type CFAppStatus struct {
 	Conditions []metav1.Condition `json:"conditions"`
 
 	// Deprecated: No longer used
-	// +kubebuilder:validation:Optional
+	//+kubebuilder:validation:Optional
 	ObservedDesiredState DesiredState `json:"observedDesiredState"`
 
 	// VCAPServicesSecretName contains the name of the CFApp's VCAP_SERVICES Secret, which should exist in the same namespace
+	//+kubebuilder:validation:Optional
 	VCAPServicesSecretName string `json:"vcapServicesSecretName"`
 
 	// VCAPApplicationSecretName contains the name of the CFApp's VCAP_APPLICATION Secret, which should exist in the same namespace
+	//+kubebuilder:validation:Optional
 	VCAPApplicationSecretName string `json:"vcapApplicationSecretName"`
 }
 

diff --git a/helm/korifi/controllers/crds/korifi.cloudfoundry.org_cfapps.yaml b/helm/korifi/controllers/crds/korifi.cloudfoundry.org_cfapps.yaml
@@ -190,8 +190,6 @@ spec:
                 type: string
             required:
             - conditions
-            - vcapApplicationSecretName
-            - vcapServicesSecretName
             type: object
         type: object
     served: true