Don't schedule a delayed job for "docker" package deletion #4103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* there are no blobs associated with packages of type "docker", so we don't need to schedule a background job
|
LGTM |
kathap
approved these changes
Nov 22, 2024
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Nov 22, 2024
Changes in cloud_controller_ng:
- Don't schedule a delayed job for "docker" package deletion
PR: cloudfoundry/cloud_controller_ng#4103
Author: Jochen Ehret <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A short explanation of the proposed change:
Don't schedule blob deletion background jobs when a Docker app is deleted.
An explanation of the use cases your change solves
For Docker apps, the packages do not have an associated blob in the blobstore. So it's not necessary to schedule a delayed job. If there is a large number of packages, this can even lead to a temporary overload scenario of the cc-workers.
Links to any other associated PRs
Expire packages in "Docker" lifecycle #4102
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests