Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC0030 - 3] File-based service bindings #4026

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Commits on Oct 7, 2024

  1. Configuration menu
    Copy the full SHA
    151459e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    226bd48 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    11c6273 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    49a7795 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Adapt system env presenter

    When the app feature 'file-based service bindings' is enabled,
    SERVICE_BINDING_ROOT is returned instead of VCAP_SERVICES.
    
    For an app using file-based service bindings the '/env' endpoint (i.e.
    GET /v3/apps/:guid/env) returns the following:
    
      {
        ...
        "system_env_json": {
          "SERVICE_BINDING_ROOT": "/etc/cf-service-bindings"
        },
        ...
      }
    
    The file runtime_environment/system_env_presenter_spec.rb has been
    deleted because all the tests it contained are also present in
    system_environment/system_env_presenter_spec.rb.
    philippthun committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    f701088 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2024

  1. Bump BBS protos

    philippthun committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    ca04e0d View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2024

  1. Add builder for service binding files

    - validate binding names and (credential) keys
    - check for duplicate binding names
    - check the total bytesize, maximum allowed size is 1MB
    - files are added in the following order:
       1. credential keys
       2. VCAP_SERVICES attributes
       3. 'type' and 'provider'
    - in case a credential key equals a VCAP_SERVICES attributes or 'type'
      or 'provider', it will be overwritten
    - for VCAP_SERVICES attribute names, underscores are replaced by hyphens
    - file content is serialized as JSON (non-string objects)
    philippthun committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    3cd5c42 View commit details
    Browse the repository at this point in the history
  2. Use ServiceBindingFilesBuilder in recipe builders

    - AppRecipeBuilder -> Diego::Bbs::Models::DesiredLRP
    - TaskRecipeBuilder -> Diego::Bbs::Models::TaskDefinition
    philippthun committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    15a8a9c View commit details
    Browse the repository at this point in the history