-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC0030 - 3] File-based service bindings #4026
Draft
philippthun
wants to merge
8
commits into
cloudfoundry:main
Choose a base branch
from
sap-contributions:file-based-service-bindings
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[RFC0030 - 3] File-based service bindings #4026
philippthun
wants to merge
8
commits into
cloudfoundry:main
from
sap-contributions:file-based-service-bindings
Commits on Oct 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 151459e - Browse repository at this point
Copy the full SHA 151459eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 226bd48 - Browse repository at this point
Copy the full SHA 226bd48View commit details -
Configuration menu - View commit details
-
Copy full SHA for 11c6273 - Browse repository at this point
Copy the full SHA 11c6273View commit details -
Configuration menu - View commit details
-
Copy full SHA for 49a7795 - Browse repository at this point
Copy the full SHA 49a7795View commit details
Commits on Oct 18, 2024
-
When the app feature 'file-based service bindings' is enabled, SERVICE_BINDING_ROOT is returned instead of VCAP_SERVICES. For an app using file-based service bindings the '/env' endpoint (i.e. GET /v3/apps/:guid/env) returns the following: { ... "system_env_json": { "SERVICE_BINDING_ROOT": "/etc/cf-service-bindings" }, ... } The file runtime_environment/system_env_presenter_spec.rb has been deleted because all the tests it contained are also present in system_environment/system_env_presenter_spec.rb.
Configuration menu - View commit details
-
Copy full SHA for f701088 - Browse repository at this point
Copy the full SHA f701088View commit details
Commits on Nov 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ca04e0d - Browse repository at this point
Copy the full SHA ca04e0dView commit details
Commits on Nov 27, 2024
-
Add builder for service binding files
- validate binding names and (credential) keys - check for duplicate binding names - check the total bytesize, maximum allowed size is 1MB - files are added in the following order: 1. credential keys 2. VCAP_SERVICES attributes 3. 'type' and 'provider' - in case a credential key equals a VCAP_SERVICES attributes or 'type' or 'provider', it will be overwritten - for VCAP_SERVICES attribute names, underscores are replaced by hyphens - file content is serialized as JSON (non-string objects)
Configuration menu - View commit details
-
Copy full SHA for 3cd5c42 - Browse repository at this point
Copy the full SHA 3cd5c42View commit details -
Use ServiceBindingFilesBuilder in recipe builders
- AppRecipeBuilder -> Diego::Bbs::Models::DesiredLRP - TaskRecipeBuilder -> Diego::Bbs::Models::TaskDefinition
Configuration menu - View commit details
-
Copy full SHA for 15a8a9c - Browse repository at this point
Copy the full SHA 15a8a9cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.