Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use vec instead of arr to avoid size check and add logging in unlink #489

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use vec instead of arr to avoid size check and add logging in unlink #489

wants to merge 1 commit into from

Conversation

ShyunnY
Copy link

@ShyunnY ShyunnY commented Dec 11, 2024

What was done:

  • use Vec instead of &mut [u8] to avoid complex memory expansion when the size is insufficient
  • make unistd::unlink errors match different logs

@Noah-Kennedy Noah-Kennedy self-requested a review December 13, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Noah-Kennedy Noah-Kennedy Awaiting requested review from Noah-Kennedy

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ShyunnY