feature(blake3): add blake3 #482
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This update will change the hash of cache keys. It will invalidate every cached asset that are stored in persistent storage. So it is not a change to roll out safely easily. We suggest that this change could be control via a feature flag or something more fine-grained so that users can choose to upgrade if their use case is safe to do so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I newable in rust. I try to complete issue #47
On my machine(MacBook Pro 16-inch, 2021), blake3 better then blake2
blake3
time: [2.5446 s 2.5564 s 2.5685 s]
blake2
time: [2.6089 s 2.6220 s 2.6349 s]
blake2
[+1.8579% +2.5679% +3.2462%]
And I don't know what other proofs need from me :) dhat.jsons ?
This PR is nominated at RU RustCon Contest