Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a dummy TLS implementation to be used as fallback #277

Closed
wants to merge 2 commits into from

Conversation

palant
Copy link
Contributor

@palant palant commented Jun 11, 2024

I’ve added a dummy TLS implementation to be used when neither OpenSSL nor BoringSSL are selected, providing only the APIs actually used by Pingora. This is a step towards solving two issues:

  1. Pingora currently cannot compile without TLS support, yet sometimes an HTTP-only server is sufficient.
  2. Someone aiming to provide another TLS implementation (e.g. [ feature request ] Use rustls #29) has no way of knowing which parts of the vast OpenSSL API actually have to be reproduced.

This at least gets Pingora to compile with --no-default-features. It will still fail at startup because it attempts to initialize some TLS connectors, some more work is required here. Also, quite a few tests rely on TLS being available – these probably need to run conditionally.

@drcaramelsyrup drcaramelsyrup added the enhancement New feature or request label Jun 14, 2024
@johnhurt johnhurt added the Accepted This change is accepted by us and merged to our internal repo label Aug 2, 2024
@johnhurt
Copy link
Contributor

johnhurt commented Aug 2, 2024

@palant, I should have marked this as Accepted weeks ago. It should be coming out in the weekly sync today or next week at the latest. You know the drill, once it does, I'll mark this as closed. Thanks for all your excellent contributions!

johnhurt pushed a commit that referenced this pull request Aug 23, 2024
---
Added some more exports used by the server example

Includes-commit: d7be54b
Includes-commit: e36e6e7
Replicated-from: #277
@johnhurt
Copy link
Contributor

johnhurt commented Aug 23, 2024

Hey, this has been merged ... Or it will be in a few minutes. Thanks!

johnhurt pushed a commit that referenced this pull request Aug 23, 2024
---
Added some more exports used by the server example

Includes-commit: d7be54b
Includes-commit: e36e6e7
Replicated-from: #277
@eaufavor
Copy link
Member

Synced, thanks!

@eaufavor eaufavor closed this Aug 30, 2024
escoffier pushed a commit to escoffier/pingora that referenced this pull request Sep 6, 2024
---
Added some more exports used by the server example

Includes-commit: d7be54b
Includes-commit: e36e6e7
Replicated-from: cloudflare#277
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted This change is accepted by us and merged to our internal repo enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants