Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix example in ctx.md #167

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Abdallah-Zidan
Copy link

fix check_beta_user function parameter type

fix check_beta_user function parameter type
@eaufavor eaufavor added the documentation Improvements or additions to documentation label Mar 29, 2024
@eaufavor
Copy link
Member

Both are correct and our current doc in the doc matches the code here.

@eaufavor eaufavor self-assigned this Mar 29, 2024
@Abdallah-Zidan
Copy link
Author

Thanks for clarification
I think following the guide failed with me because in the shared example Cargo.toml here there is this line

pingora-http = { version = "0.1.0", path = "../pingora-http" } 

but I followed the guide to use these dependencies

[dependencies]
async-trait="0.1"
pingora = { version = "0.1", features = [ "lb" ] }       

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants