Disable hibernation properly #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
third774
commented
Oct 17, 2024
| @@ -170,6 +172,10 @@ export class ChatRoom extends Server<Env> { | |||
| const roomStateMessage = JSON.stringify(roomState) | |||
|
|
|||
| for (const connection of this.getConnections()) { | |||
| // skip connection if it's not OPEN | |||
| if (connection.readyState !== WebSocket.OPEN) { | |||
There was a problem hiding this comment.
It seems like partyserver's InMemoryConnectionManager is behaving differently from the HibernatingConnectionManager, and connections aren't being removed after a failed attempt to broadcast, so we need to manually skip them for now.
astroza
approved these changes
Oct 18, 2024
nils-ohlmeier
approved these changes
Oct 18, 2024
third774
force-pushed
the
disable-hibernation-properly
branch
from
4da4c87
to
f66d932
Compare
|
Removed our workaround and upgrade partyserver since this has been fixed upstream threepointone/partyserver#93 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.