Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cloudflare-tunnel-remote/charts): apply securityContext from values.yaml #67

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bryopsida
Copy link

@bryopsida bryopsida commented Feb 17, 2024

What

The charts/cloudflare-tunnel-remote chart defines values for securityContext:

and podSecurityContext:

but does not apply them to the pod template in deployment.

This simply maps the intended securityContext values into the appropriate locations on the template.

How to test

You can verify the template changes by running helm template . inside the remote chart directory.

Evidence

 spec:
      serviceAccountName: release-name-cloudflare-tunnel
      securityContext:
        runAsNonRoot: true
        runAsUser: 65532
      containers:
        - name: cloudflare-tunnel
          securityContext:
            allowPrivilegeEscalation: false
            capabilities:
              drop:
              - ALL
            readOnlyRootFilesystem: true
          image: "cloudflare/cloudflared:2023.5.1"

@bryopsida
Copy link
Author

Looks like there's overlap between this and #65.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant