Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-27671 Updated environment deletion states, handled null cascading delete option #174

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

daszabo
Copy link
Contributor

@daszabo daszabo commented Nov 5, 2024

No description provided.

@daszabo daszabo requested a review from a team as a code owner November 5, 2024 13:45
@daszabo daszabo requested a review from gregito November 5, 2024 13:50
Copy link

github-actions bot commented Nov 5, 2024

Go test coverage: 33.6% for commit 5d49a5c
⚠️ 2 of 14 packages have zero coverage.
  • github.com/cloudera/terraform-provider-cdp/resources/de
  • github.com/cloudera/terraform-provider-cdp/resources/ml
View coverage for all packages
# Package Name                                                                  | Coverage
+ github.com/cloudera/terraform-provider-cdp/cdpacctest                         |    26.9%
+ github.com/cloudera/terraform-provider-cdp/provider                           |    78.7%
+ github.com/cloudera/terraform-provider-cdp/resources/datahub                  |    36.3%
+ github.com/cloudera/terraform-provider-cdp/resources/datalake                 |     8.4%
- github.com/cloudera/terraform-provider-cdp/resources/de                       |     0.0%
+ github.com/cloudera/terraform-provider-cdp/resources/dw/cluster/aws           |    72.4%
+ github.com/cloudera/terraform-provider-cdp/resources/dw/databasecatalog       |    66.7%
+ github.com/cloudera/terraform-provider-cdp/resources/dw/virtualwarehouse/hive |    74.3%
+ github.com/cloudera/terraform-provider-cdp/resources/environments             |    44.1%
+ github.com/cloudera/terraform-provider-cdp/resources/iam                      |     2.8%
- github.com/cloudera/terraform-provider-cdp/resources/ml                       |     0.0%
+ github.com/cloudera/terraform-provider-cdp/resources/opdb                     |    25.3%
+ github.com/cloudera/terraform-provider-cdp/utils                              |    55.3%
+ github.com/cloudera/terraform-provider-cdp/utils/test                         |    68.8%

@gregito
Copy link
Contributor

gregito commented Nov 5, 2024

why do we set the cascade deletion to true when it is false by default both on the UI and the CLI?

@daszabo
Copy link
Contributor Author

daszabo commented Nov 5, 2024

I intended it as a fail-safe. Also I don't see the point of this option anyway, because if someone wants to delete the environment, sureley they want to delete the data lake and datahubs as well

@daszabo daszabo merged commit 6362328 into main Nov 5, 2024
9 checks passed
@daszabo daszabo deleted the CB-27671 branch November 5, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants