Data Warehouse acceptance tests for catalog, hive

[tevesz]

Cover the dw environment, db catalog and hive virtual warehouse creations and deletions as part of acceptance testing.

[github-actions]

Go test coverage: 33.4% for commit 0e7569e

⚠️ 2 of 14 packages have zero coverage.

• github.com/cloudera/terraform-provider-cdp/resources/de
• github.com/cloudera/terraform-provider-cdp/resources/ml

View coverage for all packages

# Package Name                                                                  | Coverage
+ github.com/cloudera/terraform-provider-cdp/cdpacctest                         |    14.3%
+ github.com/cloudera/terraform-provider-cdp/provider                           |    78.7%
+ github.com/cloudera/terraform-provider-cdp/resources/datahub                  |    36.3%
+ github.com/cloudera/terraform-provider-cdp/resources/datalake                 |     8.4%
- github.com/cloudera/terraform-provider-cdp/resources/de                       |     0.0%
+ github.com/cloudera/terraform-provider-cdp/resources/dw/cluster/aws           |    72.4%
+ github.com/cloudera/terraform-provider-cdp/resources/dw/databasecatalog       |    66.7%
+ github.com/cloudera/terraform-provider-cdp/resources/dw/virtualwarehouse/hive |    74.3%
+ github.com/cloudera/terraform-provider-cdp/resources/environments             |    44.1%
+ github.com/cloudera/terraform-provider-cdp/resources/iam                      |     2.8%
- github.com/cloudera/terraform-provider-cdp/resources/ml                       |     0.0%
+ github.com/cloudera/terraform-provider-cdp/resources/opdb                     |    25.3%
+ github.com/cloudera/terraform-provider-cdp/utils                              |    55.3%
+ github.com/cloudera/terraform-provider-cdp/utils/test                         |    68.8%

[tevesz]

I think I've addressed all comments @vcsomor and @gregito , thanks for the review! There is one thing I want to make sure about, the Aws Profile (or other aws cred variable) will be needed for the DW acceptance runs, to deploy the roles and policies, is there any change that I should add for this? Like support secret access keys?

[vcsomor]

There is one thing I want to make sure about, the Aws Profile (or other aws cred variable) will be needed for the DW acceptance runs, to deploy the roles and policies, is there any change that I should add for this? Like support secret access keys?

I don't know if I got this right. We can add further possibilities once they are required.
In general, the underlying AWS SDK knows the best how to initialize the client. The best way is to assign roles to the APP/TEST/CONTAINER/VM trying to access the AWS API and the SDK just initializes with the LoadDefaultConfig.
The next least good solution is to go with profiles, the most insecure is the accesskey/secretkey pair.

[tevesz]

@vcsomor this is a question because the acc test is run by a jenkins job, and that most probably already has a couple of options to handle the secrets. Technically my question is what kind of secrets are required or provided by the jenkins infra.