Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use winkerberos on windows #504

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jcrist
Copy link

@jcrist jcrist commented Oct 18, 2022

This switches impyla to depend on winkerberos on windows rather than kerberos. The winkerberos package provides pre-built wheels for windows with the same python-facing API.

Fixes #466.

This switches impyla to depend on `winkerberos` on windows rather than
`kerberos`. The `winkerberos` package provides pre-built wheels for
`windows` with the same python-facing API.
@jcrist jcrist force-pushed the use-winkerberos-on-windows branch from a078a86 to 4bd7592 Compare October 18, 2022 19:26
@csringhofer
Copy link
Collaborator

Thanks for working on this!
I agree that it would be much better to use a Kerberos module with prebuilt binaries.

I have concerns about testing though: I don't know whether anyone tests Impyla with Windows + Kerberos, so it seems possible to break some use cases without noticing it. All the test environments I know about are Linux based.
Are there relevant tests in the Ibis project?

@jcrist
Copy link
Author

jcrist commented Dec 15, 2022

Are there relevant tests in the Ibis project?

There are not, and I also have no way to test this. I've had similar code in place for years in another kerberos-related project though with no complaints, but this may just mean that no one is using it on windows :).

This PR was quick to work up, no pressure at all to merge it. Apologies that I can't be more help here ensuring this is correct.

@csringhofer
Copy link
Collaborator

I started asking around about Impyla + Windows + Kerberos inside Cloudera.

I was thinking about an alternative in case switching to winkerberos from kerberos would be problematic for some people:

  • the order of importing could reversed, so impyla would try winkerberos only if importing kerberos has failed
  • a new extra name could be used, e.g. kerberos_with_winkerberos_on_windows or kerberos_prebuilt

This way an easy installation could be provided on Windows without the chance of breaking any existing use cases.

@csringhofer
Copy link
Collaborator

csringhofer commented Feb 23, 2023

I started asking around about Impyla + Windows + Kerberos inside Cloudera.

I didn't get any feedback yet about this setup.
I am still concerned about possible breaking some existing workflows, so I would prefer to use the solution I wrote above, so first try importing kerberos and then winkerberos (if os.name == 'nt').

@jcrist Is it ok for you to proceed this way?

csringhofer added a commit to csringhofer/impyla that referenced this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows Kerberos Support
2 participants