[ui-core] adds useQueueProcessor hook to manage concurrent async task #3890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramprasadagarwal
requested review from
tabraiz12,
JohanAhlen,
bjornalm and
nidhibhatg
bjornalm
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Looks good but I have a couple of questions for you to explore. Also see comment and potentially fix the "unsafe" state mutation
-What happens if I use this from my parent component, start a process of 100 items one at a time and then wants to cancel?
-What happens if I unmount my parent component during the process?
-Any risk for unexpected continued processing or memory leaks in the above scenarios?
| ); | ||
|
|
||
| const processQueueItem = async () => { | ||
| const nextItem = pendingQueue.shift(); |
There was a problem hiding this comment.
This is modifying the state without using setPendingQueue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
How was this patch tested?