Fix logout_url in different Control pane #3882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranade1
requested review from
wing2fly,
Harshg999,
amitsrivastava,
quadoss,
athithyaaselvam and
agl29
ranade1
force-pushed
the
prakash-master
branch
from
7f4f8f2
to
6438c08
Compare
amitsrivastava
approved these changes
Nov 15, 2024
athithyaaselvam
approved these changes
Nov 15, 2024
|
|
quadoss
reviewed
Nov 15, 2024
There was a problem hiding this comment.
@ranade1 , The 2 elif has consoleauth/logout to be available in logout_url if one of the condition satisfy would it not pick the staging-upgrade one?
Also the elif has 'and' condition, so we are expecting all the condition to satisfy?
I have given him the walkthrough and reasoning behind those 2 elif logic. @quadoss is OK with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
How was this patch tested?
Please review Hue Contributing Guide before opening a pull request.