Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pytest] Add warning for PRs missing unit test file changes #3875

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

agl29
Copy link
Collaborator

@agl29 agl29 commented Oct 24, 2024

What changes were proposed in this pull request?

  • Add warning for PRs missing unit test file changes.
  • Committers and reviewers will be notified if the PR includes changes to unit test files.

How was this patch tested?

  • Locally
  • Github Action

@agl29 agl29 force-pushed the ptest-codecov branch 3 times, most recently from 8bc2d43 to dc4d08d Compare October 24, 2024 12:13
@cloudera cloudera deleted a comment from github-actions bot Oct 24, 2024
@cloudera cloudera deleted a comment from github-actions bot Oct 24, 2024
@cloudera cloudera deleted a comment from github-actions bot Oct 24, 2024
@cloudera cloudera deleted a comment from github-actions bot Oct 24, 2024
@cloudera cloudera deleted a comment from github-actions bot Oct 24, 2024
@cloudera cloudera deleted a comment from github-actions bot Oct 24, 2024
@agl29 agl29 force-pushed the ptest-codecov branch 2 times, most recently from 4d00628 to 3302159 Compare November 11, 2024 07:03
@cloudera cloudera deleted a comment from github-actions bot Nov 11, 2024
@agl29 agl29 changed the title [pytest] add pytest-cov [pytest] Add warning for PRs missing unit test file changes Nov 11, 2024
@cloudera cloudera deleted a comment from github-actions bot Nov 11, 2024
@cloudera cloudera deleted a comment from github-actions bot Nov 11, 2024
.github/workflows/commitflow-py3.yml Outdated Show resolved Hide resolved
desktop/core/base_requirements.txt Outdated Show resolved Hide resolved
desktop/libs/notebook/src/notebook/connectors/trino.py Outdated Show resolved Hide resolved
.github/workflows/commitflow-py3.yml Show resolved Hide resolved
@cloudera cloudera deleted a comment from github-actions bot Nov 13, 2024
@cloudera cloudera deleted a comment from github-actions bot Nov 13, 2024
Copy link

⚠️ No unit test files modified. Please ensure that changes are properly tested. ⚠️

Copy link
Contributor

@JohanAhlen JohanAhlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link

⚠️ No unit test files modified. Please ensure that changes are properly tested. ⚠️

@agl29 agl29 merged commit b1d5856 into master Nov 13, 2024
5 of 6 checks passed
@agl29 agl29 deleted the ptest-codecov branch November 13, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants