Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Trino] Add a flag to distinguish between the database and table/column name #3867

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

agl29
Copy link
Collaborator

@agl29 agl29 commented Oct 16, 2024

What changes were proposed in this pull request?

  • Add a flag to distinguish between the database and table/column name
  • Since we are formatting the identifier, we want to ensure that table or column names with special characters are not broken.

How was this patch tested?

  • Locally

@agl29 agl29 force-pushed the trino_spec_char_table branch 4 times, most recently from 2c69477 to 60f478a Compare October 17, 2024 08:07
@agl29 agl29 requested review from JohanAhlen and Harshg999 and removed request for JohanAhlen October 17, 2024 08:08
Copy link
Contributor

@JohanAhlen JohanAhlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agl29 agl29 enabled auto-merge (squash) October 17, 2024 10:52
@agl29 agl29 merged commit 2e10b71 into master Oct 17, 2024
5 of 6 checks passed
@agl29 agl29 deleted the trino_spec_char_table branch October 17, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants