Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LITE-28144: added cnavbar and cview components #25

Closed
wants to merge 1 commit into from

Conversation

victor-cuevas
Copy link
Collaborator

@victor-cuevas victor-cuevas marked this pull request as draft October 3, 2023 14:16
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 3, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

22.2% 22.2% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link
Collaborator

@paulinaczybir paulinaczybir Oct 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add unit tests for this component

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! On it, that's why it's on draft :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahhh sure, just realised it's still draft:)

@paulinaczybir
Copy link
Collaborator

paulinaczybir commented Oct 4, 2023

Please add storybook stories for the new components. Use of the components needs to be documented to make it clear which props are available and verify appearance and behavior

@arnaugiralt arnaugiralt self-requested a review October 5, 2023 08:03
@victor-cuevas victor-cuevas deleted the feature/LITE-28144 branch October 13, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants