Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update vm-memory version #4

Open
wants to merge 1 commit into
base: dragonball
Choose a base branch
from

Conversation

liubogithub
Copy link

vm-memory 0.3.0 has removed integer-atomics as distinct feature.

Signed-off-by: Liu Bo [email protected]

@liubogithub
Copy link
Author

fuse-backend-rs fails to build because of vm-memory version conflict.

@liubogithub
Copy link
Author

liubogithub commented Nov 25, 2020

@sameo Hi, could you please help merge this commit? it's required by this fuse-backend-rs pr

cloud-hypervisor/fuse-backend-rs#10

@sameo
Copy link
Member

sameo commented Nov 25, 2020

@liubogithub vm-memory moved to 0.4.0 a few days ago. I think we should move both fuse-backend and this crate to that release.

@jiangliu
Copy link

@liubogithub vm-memory moved to 0.4.0 a few days ago. I think we should move both fuse-backend and this crate to that release.

The vm-memory 0.4 version has fixed a performance regression issue:)

@sameo
Copy link
Member

sameo commented Nov 25, 2020

@liubogithub vm-memory moved to 0.4.0 a few days ago. I think we should move both fuse-backend and this crate to that release.

The vm-memory 0.4 version has fixed a performance regression issue:)

A pretty big one, yes :)

@liubogithub
Copy link
Author

OK, I will update both accordingly.

vm-memory 0.3.0+ has removed integer-atomics as distinct feature.

Sameo suggested vm-memory 0.4.0 as it has fixed a performance issue.

Signed-off-by: Liu Bo <[email protected]>
@jiangliu
Copy link

Please also pay attention to that, there's no methods to access guest memory atomically. If there are concurrently accesses to the same fields from guest and vmm side, we need to use atomic access interfaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants