[WIP] Support for Theming #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A theme represents the combination of markdown, code and preview styles.
A collection of themes that can be loaded from a JSON file.
Add JsonThemeTranslator class to translate between JSON and Theme objects.
Add methods to retrieve a theme by name or the names of all themes to the ThemeCollection class.
It manages a theme collection and the association to the builtin markdown, code and preview styles
Remove the specific style actions from the main window and use the ThemeManager instead to fill the Styles submenu. Also rename option lastUsedStyle to lastUsedTheme.
* Remove theme collection management from ThemeManager * Rename ThemeManager to StyleManager. The class is now responsible for mapping style names in themes to paths to style file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Load themes from JSON file instead of hardcoding them. This should be the start to add custom themes.
Replaces PR #190