Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(express): Support Express v5 #4201

Merged
merged 3 commits into from
Sep 23, 2024
Merged

feat(express): Support Express v5 #4201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb222c3
feat(express): Support Express v5
wobsoriano Sep 20, 2024
2155fa1
chore: add changeset
wobsoriano Sep 20, 2024
83c09a2
chore(express): Bump changeset to major version
wobsoriano Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/three-falcons-glow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@clerk/express": major
---

Add support for Express 5
3 changes: 3 additions & 0 deletions packages/express/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,9 @@
"tsup": "*",
"typescript": "*"
},
"peerDependencies": {
"express": "^4.17.0 || ^5.0.0"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we support v5 out-of-the-box actually but we want to set a more stable minimum v4 version to prevent any breaking change in earlier versions

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clerk/express is still v0. Are we doing v1 after this PR, or we wait for Express 5 to be cut as latest and then do v1 ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets do v1 now unless we know that express v5 is coming out soon

Copy link
Member Author

@wobsoriano wobsoriano Sep 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference, here's the pending items before they tag v5 as latest:

Screenshot 2024-09-23 at 7 52 45 AM

Mostly docs update, so I think latest tag will come soon. Let's go v1 major? v5 is backwards compatible anyway...

},
"engines": {
"node": ">=18.17.0"
},
Expand Down
Loading