Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make temporary file location a variable. #29

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

dglinder
Copy link

This removes the need for "/opt/" to be writable by a users and permits the script to be run by non-root users.

I took the liberty of updating the comment lines so future work to re-activate them should work as well.

@clemenko
Copy link
Owner

Between the two PRs you have added 3 features.

  1. opt --> /var/tmp
  2. docker login
  3. hauler binary location

I am not sure these are all needed. The theory of this script is to create all the hauler tar for getting all the bits to create a rancher cluster air gapped.

  1. Actually I think I am find with the temp location. If you want to create a PR just for that, that is cool.
  2. why do you need a docker login? the script works without that.
  3. Why the hauler location? the script will download hauler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants