Don't skip patches if mapped grid used #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of always setting to True if not set by user, set to False if there is a mapc2p function for some item, since it doesn't work properly in this case. clawpack#278
mandli
reviewed
Sep 22, 2020
|
Oops, @mandli merged before I made another change of name. I'll open a new PR. |
|
Ah sorry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address #278.
If the user hasn't set
plotaxes.skip_patches_outside_xylimitsthen the internalskip_patches_outside_xylimitswill be set toTrueonly if there is nomap2cpfunction specified for theplotdataor anyplotitem.We need a better approach in general.