Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #740: file_prefix argument is inconsistently implemented in fileio.ascii.py #741

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

MohitKambli
Copy link
Contributor

Hello,
Hope you're doing well
As it has been requested in #740, I have eliminated the hard-coded substring fort and injected the file_prefix variable instead to lines 53 and 65 respectively
Kindly let me know if the code changes meet the requirements
Sincere apologies for my mistakes if you find any

Thanks and Regards,
Mohit Kambli

@coveralls
Copy link

Coverage Status

coverage: 26.759%. remained the same
when pulling cf07f27 on MohitKambli:pyclaw-branch
into f55b884 on clawpack:master.

@MohitKambli
Copy link
Contributor Author

Hello @mandli @coveralls,
Hope you're doing well
Just so that we're on the same page, this PR has been raised for solving issue #740
On introducing the mentioned code changes, I am able to see the following error in the build logs
AttributeError: module 'clawpack.riemann.static' has no attribute 'fwave'
I tried to figure out the possible root cause of this error, but still not able to figure out
Could you please help me in solving this issue or the possible reason for such error?
It would be a big help from your end

Thanks and Regards,
Mohit Kambli

@mandli
Copy link
Member

mandli commented Dec 26, 2024

This is due to a broader change to the Riemann solvers used and requires clawpack/clawpack#259 to be merged in first. It works locally though for me.

@mandli mandli merged commit cc2a32e into clawpack:master Dec 26, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants