Skip shallow water on the sphere test on Github to avoid segfault. #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to go ahead and merge this since the tests pass, so that we can continue work on #735. |
Merged
|
Why when I run locally do I not have a shallow water segfault, but I do get a failure on one the advection tests? Are these tests just numerically brittle or something? They should be robust to different systems/environments. I think this merits its own issue, if one doesn't already exist for this problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is hopefully temporary, and will allow us to get coverage working again. Coverage currently doesn't work because this test crashes the whole process. See #735.