Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move num_dim determination futher up #223

Closed
wants to merge 2 commits into from
Closed

Move num_dim determination futher up #223

wants to merge 2 commits into from

Conversation

mandli
Copy link
Member

@mandli mandli commented Jun 17, 2018

Partially addresses #221.

@mandli mandli requested a review from mjberger June 17, 2018 02:43
@rjleveque
Copy link
Member

Do we want to still handle the special case of doing 1d amr with 2d, now that src/1d exists?

@mandli
Copy link
Member Author

mandli commented Jun 17, 2018

No but I was not sure if someone was either using this or wanted to keep the ability around. I am ok with removing it myself.

@mandli
Copy link
Member Author

mandli commented Jun 17, 2018

Removed the 1D output now.

@mandli mandli mentioned this pull request Aug 10, 2018
Merged
@mandli mandli closed this Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjberger mjberger Awaiting requested review from mjberger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mandli @rjleveque