-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug Fixes, Page Aliases, Redaction, Local Media, Layout Customization, Asset Imports & Case (De)Sensitivity #247
Open
rj919
wants to merge
34
commits into
claudioc:master
Choose a base branch
from
rj919:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…guration fields to config.js; added validation of new configuration fields;
…ion of sidebar, footer and main columns to layout.pug;
…n; fixed bug in gitmech.gitExec when handling absolute paths with blank spaces;
…edirection functionality to wiki page and link interpolation; updated default redaction expressions in config; TODO: add validation of redaction expressions and validate date fields exist in earliestDate;
…ummaries as option in config; TODO: add redactContent and pageSummaries to pug templates; add validation of redaction expressions and validate date fields exist in earliestDate; integrate redaction RegExp tests to redactor.redact;
…h search result fetching; TODO: add validation of redaction expressions and validate date fields exist in earliestDate; integrate redaction RegExp tests to redactor.redact;
… hidden, private and date based redaction; TODO: finish rollout sections RegExp tests to redactor.redact; TODO: add media to routes served
…to routes served;
…ch.js; added override of standard favicon with favicon in media folder;
…untu; added option to serve files from local copies rather than CDNs to config; removed case sensitive toggle from search results - now case sensitivity applies only to redirect names;
…ction matches; added a privateComments redaction option to allow for inline (non-sandwich) redaction; added README_FORK documentation for changes; TODO: finish documentation of redaction options;
…; TODO: finish documentation of redaction options;
… to config unittests;
…ated name of redaction fields;
…n be used with media folder;
…; added unittests for additional fields added to config; added documentation to README_FORK.md;
…cking for existence of link;
…itiveAliases to caseSensitive in config;
… aliases into page editing so alias can be added by live users; TODO: lift html elements outside of paragraphs during markdown rendering; TODO: add route to retrieve data files which can be redacted; TODO: add option to auto-generate tables and other data objects into page; TODO: add plugin option for a different flavor of markdown;
…nto page editing so alias can be added by live users; TODO: lift html elements outside of paragraphs during markdown rendering; TODO: add route to retrieve data files which can be redacted; TODO: add option to auto-generate tables and other data objects into page; TODO: add plugin option for a different flavor of markdown;
…e editing so alias can be added by live users; TODO: lift html elements outside of paragraphs during markdown rendering; TODO: add route to retrieve data files which can be redacted; TODO: add option to auto-generate tables and other data objects into page; TODO: add plugin option for a different flavor of markdown;
… markdown rendering; TODO: integrate aliases into page editing so alias can be added by live users; TODO: add option to auto-generate tables and other data objects into page; TODO: add plugin option for a different flavor of markdown;
@rj919 if want to take a look at Jingo 2, just give me an email address and I will share it with you (it's still in a private bitbucket repo at the moment) |
Hey Claudio,
Cool. My bitbucket account is rj88
[email protected]
.:. Richard
On Wed, Oct 3, 2018 at 8:53 AM Claudio Cicali ***@***.***> wrote:
@rj919 <https://github.com/rj919> if want to take a look at Jingo 2, just
give me an email address and I will share it with you (it's still in a
private bitbucket repo at the moment)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#247 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AGOo-LB2WlK2kOV1nDa6dorb7XXFaiqQks5uhLM6gaJpZM4WOrRV>
.
--
Richard James
Founder, Software Architect
Collective Acuity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've consolidated the features from prior pull requests with another fix to a bug in jingo's core code I uncovered as well as an additional option in configs to turn off case sensitivity to page linking. An explanation of all the features added along with the documentation for each feature can be found here:
https://github.com/rj919/jingo/blob/master/README_FORK.md
Look forward to seeing jingo v2...
As far as additional features which I have thought about but haven't been able to get to yet, here are some ideas: